Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fix #2184

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Minor bug fix #2184

merged 1 commit into from
Jan 20, 2020

Conversation

asherpasha
Copy link
Contributor

@asherpasha asherpasha commented Jan 20, 2020

Details

This pull request fixes a bug in InterMine. This bug was discovered by TACC (Texas Advanced Computing Center) security staff and reported by Erik Ferlanti.

The bug is in reports page. To test, add the following to the end of any InterMine URL (Example: bar.utoronto.ca/thalemine/):

report.do?id=108386942</title><img%20src=x%20onerror=alert(150)>&trail=%7C108386942

Testing

Please test it and let me know if you have any questions.

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • Checkstyle

@danielabutano danielabutano self-assigned this Jan 20, 2020
@danielabutano danielabutano merged commit ce33e08 into intermine:dev Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants