Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearLocation() to removeFeature() #2207

Merged
merged 1 commit into from
May 18, 2020
Merged

Add clearLocation() to removeFeature() #2207

merged 1 commit into from
May 18, 2020

Conversation

sammyjava
Copy link
Member

@sammyjava sammyjava commented Feb 18, 2020

It doesn't make sense to remove the feature without removing its associated Location -- which causes a build error because the Location gets orphaned in the Items database.

Details

Summary of pull request, including references to relevant tickets (if applicable).

Testing

Besides running unit tests, how can the reviewer test your feature / bug fix? Are there edge cases to be aware of?

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • Checkstyle

It doesn't make sense to remove the feature without removing its associated Location -- which causes a build error because the Location gets orphaned in the Items database.
@danielabutano danielabutano self-assigned this Feb 26, 2020
@danielabutano
Copy link
Member

Thanks @sammyjava . I will add to the upcoming InterMine release

@danielabutano danielabutano merged commit ce95327 into intermine:dev May 18, 2020
@danielabutano danielabutano added this to InterMine 4.2.0 (Spring 2020) in Roadmap & release planning May 18, 2020
@danielabutano danielabutano added this to the InterMine 4.2.0 milestone May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants