Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organism short name formation. #2215

Merged
merged 1 commit into from
May 18, 2020

Conversation

ahmedihafez
Copy link
Contributor

Details

I am working on Candidamine for candida species, and some organism that are loaded in the mine start with [ e.g [Candida] auris or [Candida] glabrata. This lead to a strange short name for example [.auris.
This fix such behaviour.

Summary of pull request, including references to relevant tickets (if applicable).

Testing

Besides running unit tests, how can the reviewer test your feature / bug fix? Are there edge cases to be aware of?

Checklist

Before your pull request can be approved, be sure to check all boxes:

  • Passing unit test for new or updated code (if applicable)
  • Passes all tests – according to Travis
  • Documentation (if applicable)
  • Single purpose
  • Detailed commit messages
  • Well commented code
  • Checkstyle

@danielabutano
Copy link
Member

Thanks @ahmedihafez for the PR. I wil merge it (and apply a couple of changes to fix the checkstyle) and put it in the upcoming InterMine release.
Let us know if you want to add you CandidaMine to the InterMine registry.

@danielabutano danielabutano merged commit 4fa4f6a into intermine:dev May 18, 2020
@danielabutano danielabutano self-requested a review May 18, 2020 11:12
danielabutano pushed a commit that referenced this pull request May 18, 2020
@danielabutano danielabutano added this to the InterMine 4.2.0 milestone May 18, 2020
@danielabutano danielabutano added this to InterMine 4.2.0 (Spring 2020) in Roadmap & release planning May 18, 2020
@ahmedihafez
Copy link
Contributor Author

Many thanks @danielabutano.
Yes I would like to add candidamine to the InterMine registry, Please let me know what I can do to add it.
Many thanks for your help.

@ahmedihafez ahmedihafez deleted the entrez-organism-fix branch June 10, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants