Remove BioEntity.ontologyAnnotations (redundant) #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioEntity extends Annotatable so it already has ontologyAnnotations. Removing from the BioEntity definition to avoid confusion. (And because I'm picky.)
|
Thanks @sammyjava . I will add in the upcoming InterMien relase |
danielabutano
added this to InterMine 4.2.0 (Spring 2020)
in Roadmap & release planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BioEntity extends Annotatable so it already has ontologyAnnotations. Removing from the BioEntity definition to avoid confusion. (And because I'm picky.)
Details
Summary of pull request, including references to relevant tickets (if applicable).
Testing
Besides running unit tests, how can the reviewer test your feature / bug fix? Are there edge cases to be aware of?
Checklist
Before your pull request can be approved, be sure to check all boxes: