Update CI to use Python 3.7 #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although could a None testcase mean something went wrong?
3.8 actually looked fine - the tests were only failing due to differing ordering of the query XML attributes, which IMO is more a bug with the tests.
3.10 failed at the setup step... which means the client itself *could* work, but now is not the time to find out.
heralden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Change CI files to use Python version 3.7 instead of 2.7 which is EOL.
Testing
Besides running unit tests, how can the reviewer test your feature / bug fix? Are there edge cases to be aware of?
Just check that CI succeeds for the PR.
Checklist
Before your pull request can be approved, be sure to check all boxes: