Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instagram behavior #109

Merged
merged 1 commit into from Jun 22, 2018
Merged

update instagram behavior #109

merged 1 commit into from Jun 22, 2018

Conversation

galgeek
Copy link
Contributor

@galgeek galgeek commented Jun 15, 2018

Motivation

ARI-5747

Description

update selector for detail image

@BitBaron
Copy link
Contributor

BitBaron commented Jun 18, 2018

Good catch but that class name still looks a little gnarly and likely to change soon. Can we try something a little less likely to be random?

My quick tests with something like this in the browse console seem to result in the same lists.
document.querySelectorAll("a>div[role='button']")

@galgeek
Copy link
Contributor Author

galgeek commented Jun 21, 2018

Thanks, @BitBaron! That selector looks like it captures the same, and it may well not need an update again so soon.

I've updated the PR.

@BitBaron BitBaron merged commit f5f9a1a into master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants