Update Ansible and Vagrant for Debian 12 #279
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insom
commented
Jun 17, 2024
| - vnc4server | ||
| - libjpeg-turbo8-dev | ||
| - chromium | ||
| - tigervnc-standalone-server |
There was a problem hiding this comment.
vnc4server has a proprietary license so I switched over to tigervnc which is in the main repositories.
| @@ -70,7 +70,7 @@ | |||
| changed_when: false | |||
|
|
|||
| - name: ensure service user {{user}} exists | |||
| user: name={{user}} system=yes createhome=no home=/nonexistent | |||
| user: name={{user}} system=yes createhome=yes home=/home/{{user}} | |||
There was a problem hiding this comment.
This user does actually have to exist, as {{user}} is used later in the warcproxy playbook. The only reason this didn't error before is because /home/vagrant is created by default by Vagrant itself. (I wasn't running inside Vagrant though, so I hit this).
| shell=/usr/sbin/nologin | ||
| become: true | ||
| when: id_user|failed | ||
| when: id_user.rc != 0 |
There was a problem hiding this comment.
This is the style suggested by the Ansible docs, although #218 suggests is failed which is nicer to read? |failed filter definitely does not work any longer.
|
(converting to draft because it looks like Xvnc is crash looping in this configuration) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu no longer packages
chromiumas a .deb, only as a snap. Debian is keeping the .deb dream alive.I've made the playbook more resilient to path changes with Python versions by using
-mvirtualenvinstead of executing the module file and usingpython3instead of expectingpythonon the system path to point to the right place.This proposed PR would lose the ability to archive Adobe Flash as no equivalent is packaged (or would work with a modern Chromium, I think?)