Search not working properly

[mitra42]

STR - strange
http://localhost:4244/arc/archive.org/details/mitratest?mirror=localhost:4244&transport=HTTP
Enter "bananas" in search
Pops up http://localhost:4244/archive/archive.html?search=bananas&item=mitratest
then back to http://localhost:4244/arc/archive.org/details/mitratest?search=bananas
Clearly wrong ...

[mitra42]

• Why is search including "item=mitratest" in URL 👍
• Why is it dropping mirror and transport: fixed by above
• Why using search= rather than query=

fixed via iaux:NavSearchLI as submit not called
See below for ongoing

[mitra42]

On dweb.archive.org it goes to ...
https://dweb.me/arc/archive.org/details/mitratest?search=bananas
And back to
https://dweb.me/arc/archive.org/details/mitratest?search=bananas
So also wrong

[mitra42]

On archive.org it goes to
https://archive.org/searchresults.php?search=bananas&sin=
which redirects to https://archive.org/search.php?query=bananas

[mitra42]

Now goes to
http://localhost:4244/arc/archive.org/details?mirror=localhost:4244&query=bananas

• Why is it dropping transport
• Search string not getting any results
• [MOVED TO Crawl indicators on Search #160 ] Check crawl indicators show up when its working

[mitra42]

Search link is http://localhost:4244/arc/archive.org/advancedsearch?output=json&q=bananas&rows=30&page=1&sort[]=-downloads&and[]=&save=yes&fl=identifier%2Ctitle%2Ccollection%2Cmediatype%2Cdownloads%2Ccreator%2Cnum_reviews%2Cpublicdate%2Citem_count%2Cloans__status__status

• Server complaining at isDownloaded on af in ArchiveItemPatched
  Complaining at file:///Volumes/Transcend/archiveorg/MindWebs_201410/MindWebs_201410_playlist.json which isnt getting converted into a AF for item 52
  Failure is in loadFromMetadataAPI (metadata looks ok)
  Problem was old playlist with %20 in it

[mitra42]

To fix the missing transport in search url

• Look at places that searchparams are played with:
  • AnchorDetailsFake,
  • archive.html
  • bootloader.html
• fix window.onpopstate in Nav.js
• rewrite the wanthistory section of Nav.{nav_search, factory}
  • take full set of parms as a opts array - then ignore searchparams
  • have callers pass copy of searchparams with certain elements stripped out with Object.filter
  • Store full set (as passed) in historystate

Cases to consider

• call from onpopstate with saved state
• process through archive.html > main > nav_search or nav_details > factory
• process from nav_details (other callers) > factory
• Obsolete pausedParm
• make sure callers pass download rather than downloaddirectory
• repeat list below in dweb_mirror and iaux
  All callers to following - pass searchparams if reqd. pass wanthistory and at least one {}
• nav_search
• factory
• nav_details
• check if pushHistory needs searchparams case
• nav_home and callers to nav_home
• nav_downloaddirectory
• AnchorDetailsFake has searchparams - maybe replace global params ?
• IAUX: NavBrandLI, NavSearchLI, AnchorDetails has searchparams
• Nav.setState to save persistent state, and pass to URLs for history

All complete, but need testing

[mitra42]

• This is done above here, but needs pushing to dweb.archive.org