Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split: Naming - move into transports then refactor #22

Closed
9 tasks done
mitra42 opened this issue Sep 1, 2019 · 17 comments
Closed
9 tasks done

Split: Naming - move into transports then refactor #22

mitra42 opened this issue Sep 1, 2019 · 17 comments

Comments

@mitra42
Copy link
Collaborator

mitra42 commented Sep 1, 2019

@mitra42
Copy link
Collaborator Author

mitra42 commented Sep 1, 2019

Part of #20

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 17, 2019

  • Consider Making naming a set of functions that can be applied in turn

Naming.p_namingcb
Stored in Transports.namingcb
< p_resolveNames array -> array
< top of most of Transports.xxx

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 17, 2019

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 18, 2019

  • Moving from /arc/archive.org/xxx to /xxx

  • scan all code for /arc/archive.org: DM DA DAC IAUX DTS

  • Forward of /arc/archive.org/* to /* replaces more specific forwards

  • Check Naming.js (and then rescan DTS for /arc/archive.org)

  • DA.ReactSupport.ReactConfig.tabbyrootinsert - hard links to dweb, unused, removed

  • DAC.Util.gateway urls - see below

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 18, 2019

  • remove most references to dweb:
    • Scan all code
      • DM
      • DA
      • DAC
      • IAUX

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 18, 2019

  • Look for /thumbnail and replace with /services/img

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 18, 2019

  • Remove references to dweb.me where possible
    • See DAC.upstreamPrefix which specifies dweb.me:/arc/archive.org
    • Scan:, IAUX, DTS
    • Look for use in DM of config.archiveui.upstream
    • Look for use in DM of httpServer (as passed to DM.init
  • use dweb.archive.org/ where possible

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 18, 2019

  • DAC.Util.gateway urls - find where used and how

  • scan code turning up in DAC, DM DA

  • url_related in AIP.fetch_related & AI.relatedItems

  • url_related_local AI.relatedItems

  • url_servicesimg in

    • AIP.saveThumbnail - needs hand thinking, prob just use mapping in Naming.js
    • AM.httpUrl via gatewayServer
  • urlDownload MFS.seed DA.DetailsPage.DetailsIAWrap x2

  • url_default_fl n/a its a field list

  • url_playlist_local AI._fetch_metadata

  • url_metadata AF.urls

  • url_advancedsearch DAC.Util._query via gatewayserver

  • gatewayServer()

    • AI._fetch_bookreader needs special handlign as passed this.server
    • DA.ReactSupport.transportStatusAndProps calls gatewayServer/info which will fail on dweb.archive.org
    • _transportsOptions.http.urlBase - which will be wrong if gatewayServer = dweb.archive.org (I think)

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 18, 2019

Cleanup

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 19, 2019

Debugging on dweb.archive.org (code loaded locally)

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 19, 2019

Debugging from edge case tests at internetarchive/dweb-archive#120

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 20, 2019

Tests on dweb.archive.org
(W) needs webpack (P) needs push/pipeline (D) deploying (T) needs test

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 23, 2019

Running through test cases on internetarchive/dweb-archive#120

  • @mitra - cant find images/notfound.png :-)
  • JourneysInPersiaAndKurdistanVolII and EnglishTeluguDictionary work on dweb.archive.org, retest on localhost

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 27, 2019

https://dweb.archive.org/details/@mitra -> notfound.png -> image not found

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 28, 2019

@mitra42
Copy link
Collaborator Author

mitra42 commented Nov 29, 2019

All above done or with own issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant