Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JavaDNS to be disabled as part of resolving outstanding build and test issues #190

Merged
merged 11 commits into from
Oct 13, 2017

Conversation

anjackson
Copy link
Collaborator

This is an attempt to resolve some issues that have been de-stabilising the build process on Travis CI, and may have contributed to #175 & #176.

  • Allow JavaDNS to be disabled so that the StatisticsSelfTest becomes reproducible on a wider range of networks (specifically, where DNS cannot be used to resolve localhost).
  • Make OneLineSimplyLayout part of commons to avoid confusing errors (see Missing OneLineSimpleLayout class file #173).
  • Use the build output folder as a temporary directory space rather than /tmp/.

Travis CI aggressively wipes /tmp/ so the build fails seemingly at random if we use it. I suspect the assumption that /tmp/ is a good place to write to is also part of the problems seen in #175 and #176.

@nlevitt nlevitt merged commit dd88191 into internetarchive:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants