Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set JUnit version to latest #296

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Conversation

hennekey
Copy link
Contributor

Updating JUnit to begin updating the unit tests

Updating JUnit to begin updating the unit tests
@ato
Copy link
Collaborator

ato commented Jan 20, 2020

I'm no maven expert but my (possible wrong) understanding is setting the version in dependencyManagement only works if junit is referred to in a normal dependencies section without a version tag. Since commons/pom.xml pulls in junit as a compile-time dependency with an explicit version I don't think this patch actually has any effect?

Allow the parent POM to specify the version
@hennekey
Copy link
Contributor Author

You're right about commons. I can fix that.
I think setting the version in dependencyManagement in the parent POM is a good idea because all the children can make use of that to be on the same version. My motivation for this is to allow me to update/add unit tests along the way, and I'm no longer familiar with JUnit 3.

@ato ato merged commit 9927e13 into internetarchive:master Jan 23, 2020
@ato
Copy link
Collaborator

ato commented Jan 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants