Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file.external_identifer can be an array of strings #14

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

iisa
Copy link
Contributor

@iisa iisa commented Aug 18, 2022

ex. https://archive.org/metadata/cd_taylor-swift_taylor-swift
has file info with a list of external_identifiers

{
"name": "disc1/01. Taylor Swift - Tim McGraw.flac",
"source": "original",
"mtime": "1515314129",
"size": "28581095",
"md5": "748e4988def50a1d271007d9855665fa",
"crc32": "4873b495",
"sha1": "f65a750cf86b87f43d4117e87f8b0271744b3036",
"format": "Flac",
"length": "234.55",
"height": "640",
"width": "640",
"private": "true",
"album": "Taylor Swift",
"comment": "https://archive.org/details/cd_taylor-swift_taylor-swift",
"title": "Tim McGraw",
"artist": "Taylor Swift",
"track": "1",
"external-identifier": [
"urn:acoustid:c1b6f24a-d9c3-400f-80d1-2c13d9a47bfd",
"urn:mb_recording_id:4bea9dc0-11d3-4dc1-936b-73361da356eb",
"urn:spotify:track:0Om9WAB5RS09L80DyOfTNa",
"urn:youtube:GkD20ajVxnY"
],
"external-identifier-match-date": [
"acoustid:2018-12-17T12:25:12Z",
"mb_recording_id:2018-09-13T11:48:54Z",
"spotify:2018-08-22T17:20:06Z",
"youtube:2018-07-02T03:51:23Z"
]
},

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #14 (5f4c2e6) into main (14573ed) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files          20       20           
  Lines        1325     1325           
  Branches       26       26           
=======================================
  Hits         1001     1001           
  Misses        322      322           
  Partials        2        2           
Impacted Files Coverage Δ
src/models/file.ts 58.09% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iisa iisa merged commit f189e1e into main Aug 18, 2022
@iisa iisa deleted the extend-file-types branch August 18, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants