Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEBDEV-5328 Integrate search service with beta search backend #16

Merged
merged 112 commits into from
Sep 22, 2022
Merged

WEBDEV-5328 Integrate search service with beta search backend #16

merged 112 commits into from
Sep 22, 2022

Commits on Aug 25, 2022

  1. Add new backends

    @latonv
    latonv committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    b08c343 View commit details
    Browse the repository at this point in the history

  2. Remove fetchMetadata

    @latonv
    latonv committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    9f461e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Add hit types

    @latonv
    latonv committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    5194465 View commit details
    Browse the repository at this point in the history

  2. Clean up minor doc issues

    @latonv
    latonv committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    7a3be31 View commit details
    Browse the repository at this point in the history

  3. Reinstate fetchMetadata for sake of testing

    @latonv
    latonv committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    e52c071 View commit details
    Browse the repository at this point in the history

  4. Add schema for search hits

    @latonv
    latonv committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    71ff6f1 View commit details
    Browse the repository at this point in the history

  5. Default to new metadata search

    @latonv
    latonv committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    0de2b50 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Adjust response modeling to conform to new backend

    @latonv
    latonv committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    16eb2e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Toy with decoupling SearchService from its backends

    @latonv
    latonv committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    affedd8 View commit details
    Browse the repository at this point in the history

  2. Clean up imports

    @latonv
    latonv committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    ff16e32 View commit details
    Browse the repository at this point in the history

  3. Abstract out shared search backend methods/options

    @latonv
    latonv committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    d76ab8d View commit details
    Browse the repository at this point in the history

  4. Clean up type imports

    @latonv
    latonv committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    2bfceec View commit details
    Browse the repository at this point in the history

  5. Improve documentation

    @latonv
    latonv committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    0bf27b0 View commit details
    Browse the repository at this point in the history

  6. Add hit factory and merge type for hits

    @latonv
    latonv committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    04f6cc7 View commit details
    Browse the repository at this point in the history

  7. Organize hit properties

    @latonv
    latonv committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    55cc700 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Conform search response details to PPS shape

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    81fdba5 View commit details
    Browse the repository at this point in the history

  2. Fix Hit type alias quirks

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    242dfda View commit details
    Browse the repository at this point in the history

  3. Add mediatype field to text hits

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d870ae8 View commit details
    Browse the repository at this point in the history

  4. Update mock response factory

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    51f6068 View commit details
    Browse the repository at this point in the history

  5. Add search request model

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    73d3c3e View commit details
    Browse the repository at this point in the history

  6. Document search backends

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    80e8079 View commit details
    Browse the repository at this point in the history

  7. Improve type safety of search response details

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    e35557b View commit details
    Browse the repository at this point in the history

  8. Excise metadata fetching (now in separate service)

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    874f1e4 View commit details
    Browse the repository at this point in the history

  9. Update search request params

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    f8ea8ae View commit details
    Browse the repository at this point in the history

  10. Update demo app with search type options

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    519d097 View commit details
    Browse the repository at this point in the history

  11. Remove leftover fetchMetadata bits from tests

    @latonv
    latonv committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    19056b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Collapse responses directory

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    42e252b View commit details
    Browse the repository at this point in the history

  2. Fix tests and formatting

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4c0a2c7 View commit details
    Browse the repository at this point in the history

  3. Add additional tests for new backends

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    70983cd View commit details
    Browse the repository at this point in the history

  4. Add unit tests for search response details

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    cc044e5 View commit details
    Browse the repository at this point in the history

  5. Avoid blank titles in demo

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    5c01c80 View commit details
    Browse the repository at this point in the history

  6. Better organize backend tests

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    a7d20c1 View commit details
    Browse the repository at this point in the history

  7. Rename default-search-backend and update package exports

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d947963 View commit details
    Browse the repository at this point in the history

  8. Add hit-type tests and fix boolean fields

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    2f4f107 View commit details
    Browse the repository at this point in the history

  9. Update sort params to PPS expected format

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    d5cf24a View commit details
    Browse the repository at this point in the history

  10. Toggle unhelpful eslint rules

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    8711a4d View commit details
    Browse the repository at this point in the history

  11. Update README and version

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e3fce48 View commit details
    Browse the repository at this point in the history

  12. Further clarify usage in README

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    59586be View commit details
    Browse the repository at this point in the history

  13. Add sort options to demo

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    1aa5c8a View commit details
    Browse the repository at this point in the history

  14. Address eslint complaints

    @latonv
    latonv committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    79b07bb View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Remove old advanced_search backend

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    bb2820d View commit details
    Browse the repository at this point in the history

  2. Add 'omit' option to aggregation params

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    867180b View commit details
    Browse the repository at this point in the history

  3. Fix demo app sort button

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    0349716 View commit details
    Browse the repository at this point in the history

  4. Formatting: missed a semicolon

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    40eaf2a View commit details
    Browse the repository at this point in the history

  5. Memoize search backends to avoid redundancy

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d0f480a View commit details
    Browse the repository at this point in the history

  6. Include page_type and page_target params

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    822c303 View commit details
    Browse the repository at this point in the history

  7. Better document search params

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    6d255bb View commit details
    Browse the repository at this point in the history

  8. Make new params optional, fix formatting

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    dd733b3 View commit details
    Browse the repository at this point in the history

  9. Update URL param keys to PPS expectations

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    2dc06c8 View commit details
    Browse the repository at this point in the history

  10. Add tests for page_type and page_target params

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a0efe06 View commit details
    Browse the repository at this point in the history

  11. Add unit test for omitting aggregations

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    34e8460 View commit details
    Browse the repository at this point in the history

  12. Add additional unit tests for hit types

    @latonv
    latonv committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    c9f24c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Add aggregations to demo app

    @latonv
    latonv committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c918cdd View commit details
    Browse the repository at this point in the history

  2. Formatting

    @latonv
    latonv committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    4dc0172 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Update obsolete documentation to refer to PPS

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    e7ccca7 View commit details
    Browse the repository at this point in the history

  2. Add FTS snippets to demo app

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    aea0e18 View commit details
    Browse the repository at this point in the history

  3. Fix bug disallowing falsey search params

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    1d42ac6 View commit details
    Browse the repository at this point in the history

  4. Update obsolete documentation to refer to PPS

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    467561b View commit details
    Browse the repository at this point in the history

  5. Formatting

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    799790e View commit details
    Browse the repository at this point in the history

  6. Clean up snippet return types in demo app

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    72b3dba View commit details
    Browse the repository at this point in the history

  7. Add a demo app field for setting # rows to fetch

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    5f0ea01 View commit details
    Browse the repository at this point in the history

  8. Add aggregations_size param to requests and demo app

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b5df1d4 View commit details
    Browse the repository at this point in the history

  9. Remove extra .ts extension on base-search-backend

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ac6961b View commit details
    Browse the repository at this point in the history

  10. Move backend factory method onto SearchService

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    8b5421f View commit details
    Browse the repository at this point in the history

  11. Rename SearchBackendOptions(Interface)

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    58ac608 View commit details
    Browse the repository at this point in the history

  12. Prevent empty page_type and page_target

    @latonv
    latonv committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    28d8938 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Better document search parameters

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    90ec583 View commit details
    Browse the repository at this point in the history

  2. Clarify doc wording around search URL generation

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    c75abdb View commit details
    Browse the repository at this point in the history

  3. Remove empty search service constructor

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    1f64905 View commit details
    Browse the repository at this point in the history

  4. Move backend factory tests over to search service

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    8b0df26 View commit details
    Browse the repository at this point in the history

  5. Add more documentation & clarifications

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    5bfa4b8 View commit details
    Browse the repository at this point in the history

  6. Remove unavailable search types from the enum

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    2c5b813 View commit details
    Browse the repository at this point in the history

  7. Rename some hit-related types/properties for clarity

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    e1c07fe View commit details
    Browse the repository at this point in the history

  8. Simplify result type definition

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    0239e57 View commit details
    Browse the repository at this point in the history

  9. Clarify test descriptions

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    e3a4726 View commit details
    Browse the repository at this point in the history

  10. Ensure error is not thrown for invalid hit types

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    9ca9291 View commit details
    Browse the repository at this point in the history

  11. Improve search param docs

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    6b2ff1d View commit details
    Browse the repository at this point in the history

  12. Add more documentation around search params & schemas

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    49497ae View commit details
    Browse the repository at this point in the history

  13. Improve documentation for search service interface

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    73b4fb1 View commit details
    Browse the repository at this point in the history

  14. Improve documentation for text/item hits

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    88f2e60 View commit details
    Browse the repository at this point in the history

  15. Better document aggregations_size param

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    5825bea View commit details
    Browse the repository at this point in the history

  16. Format doc comments more prettily

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    b2c3716 View commit details
    Browse the repository at this point in the history

  17. Add test for aggregations_size

    @latonv
    latonv committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    7e7530a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Move result factory method to SearchResponseDetails

    @latonv
    latonv committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    2d13b48 View commit details
    Browse the repository at this point in the history

  2. Refer to Metadata types in hit models

    @latonv
    latonv committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    cda64d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Revert rawMetadata to explicit type

    @latonv
    latonv committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a0451d8 View commit details
    Browse the repository at this point in the history

  2. Clean up type imports

    @latonv
    latonv committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    08e1421 View commit details
    Browse the repository at this point in the history

  3. Add a breakdown of the search params to the README

    @latonv
    latonv committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5f56b1c View commit details
    Browse the repository at this point in the history

  4. Normalize some search response properties to camel case

    @latonv
    latonv committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    555d087 View commit details
    Browse the repository at this point in the history

  5. Add README sections documenting search params and responses

    @latonv
    latonv committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b0d3102 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Adjust README for clarity

    @latonv
    latonv committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    0733976 View commit details
    Browse the repository at this point in the history

  2. Rename Result to SearchResult to avoid overlap with Result<T, E>

    @latonv
    latonv committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    8428bfb View commit details
    Browse the repository at this point in the history

  3. Formatting

    @latonv
    latonv committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    361bf81 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Add sorting method for aggregations

    @latonv
    latonv committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    721d533 View commit details
    Browse the repository at this point in the history

  2. Make aggregations immutable

    @latonv
    latonv committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    2f06f98 View commit details
    Browse the repository at this point in the history

  3. Correctly construct SearchRequest object

    @latonv
    latonv committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    6d05537 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Specify aggregation options type

    @latonv
    latonv committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    b9d6f5c View commit details
    Browse the repository at this point in the history

  2. Better document aggregation sort options

    @latonv
    latonv committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    e58734e View commit details
    Browse the repository at this point in the history

  3. Remove trailing whitespace

    @latonv
    latonv committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    27199fa View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Log debugging info if it is present on the response

    @latonv
    latonv committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    583c7cb View commit details
    Browse the repository at this point in the history

  2. Add debugging checkbox to demo app

    @latonv
    latonv committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    9c01a00 View commit details
    Browse the repository at this point in the history

  3. Move demo app queries into private fields

    @latonv
    latonv committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    546f47a View commit details
    Browse the repository at this point in the history

  4. Make debug info logs easier to navigate

    @latonv
    latonv committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    ce63e7a View commit details
    Browse the repository at this point in the history

  5. Document logging method and avoid errors on missing fields

    @latonv
    latonv committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    18a98e2 View commit details
    Browse the repository at this point in the history

  6. Add unit tests for debugging output

    @latonv
    latonv committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    4eb8f8e View commit details
    Browse the repository at this point in the history

  7. Export AggregationSortType

    @latonv
    latonv committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    0d79504 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Add unit test for backend options

    @latonv
    latonv committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3c152e5 View commit details
    Browse the repository at this point in the history

  2. Export search backend options interface

    @latonv
    latonv committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    c0f0bc0 View commit details
    Browse the repository at this point in the history

  3. Add unit tests for service path param

    @latonv
    latonv committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    9ba40db View commit details
    Browse the repository at this point in the history

  4. Update lit to modern version (for demo app)

    @latonv
    latonv committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    d41c50d View commit details
    Browse the repository at this point in the history

  5. Better organized backend tests

    @latonv
    latonv committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    e6e1e83 View commit details
    Browse the repository at this point in the history

  6. v0.4.0

    @latonv
    latonv committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    e500ab9 View commit details
    Browse the repository at this point in the history