WEBDEV-5583 Add filters param to handle facet/date-range constraints
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 82.05% 85.15% +3.10%
==========================================
Files 24 26 +2
Lines 1989 2405 +416
Branches 106 108 +2
==========================================
+ Hits 1632 2048 +416
Misses 345 345
Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
mmcnl
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PPS accepts a
filter_mapURL parameter that specifies constraints on metadata field values, such as including/excluding certain values or ensuring they are within a given numeric range. This PR adds afiltersparam and related types to the search service so that it can accept and pass along these constraints. This will allow constraints like selected/negative facets and date picker queries to be more cleanly passed to the PPS (rather than the current approach of joining them into the query string itself).This PR also includes several updates to the demo app, both to enable testing multiple filters and to improve readabililty/folding.