Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBDEV-5749 Add publicdate and reviewdate fields to item hit model #25

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Jan 6, 2023

Until recently, the PPS only provided publicdate and reviewdate fields for full-text search hits, not metadata hits. However, these fields are now present on responses for both types of hits.

This PR adds those two fields to the metadata (ItemHit) model to make them readily accessible to clients.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2023-01-10 03:30 UTC

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #25 (d1484b6) into main (97fb1ac) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   85.14%   85.15%           
=======================================
  Files          26       26           
  Lines        2404     2418   +14     
  Branches      108      110    +2     
=======================================
+ Hits         2047     2059   +12     
- Misses        345      347    +2     
  Partials       12       12           
Impacted Files Coverage Δ
src/models/hit-types/item-hit.ts 89.88% <85.71%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dualcnhq dualcnhq merged commit 248048c into main Jan 10, 2023
@dualcnhq dualcnhq deleted the webdev5749-item-date-fields branch January 10, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants