Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBDEV-5797 Add caching and verbose options #31

Merged
merged 7 commits into from
Jan 27, 2023
Merged

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Jan 26, 2023

This PR adds support for the caching and verbose options on search service backend instances.

The caching option indicates flags for the PPS to modify how the request interacts with the cache. The verbose option indicates whether all responses from the backend should be logged to the console (with some elements truncated, such as the hits array and aggregation buckets).

Both options are passed through automatically from the page URL if present and not otherwise specified.

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2023-01-27 04:22 UTC

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #31 (4431177) into main (d95dc6f) will increase coverage by 1.59%.
The diff coverage is 93.57%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   85.14%   86.73%   +1.59%     
==========================================
  Files          26       26              
  Lines        2417     2511      +94     
  Branches      111      122      +11     
==========================================
+ Hits         2058     2178     +120     
+ Misses        347      321      -26     
  Partials       12       12              
Impacted Files Coverage Δ
src/search-backend/base-search-backend.ts 88.78% <90.00%> (+2.62%) ⬆️
src/models/aggregation.ts 100.00% <100.00%> (+30.20%) ⬆️
src/search-service.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@latonv latonv merged commit ab9d4fa into main Jan 27, 2023
@latonv latonv deleted the webdev5797-caching-verbose branch January 27, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants