WEBDEV-5842 Add collectionTitles property to match new PPS responses
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 86.73% 87.15% +0.41%
==========================================
Files 26 26
Lines 2511 2522 +11
Branches 122 124 +2
==========================================
+ Hits 2178 2198 +20
+ Misses 321 313 -8
+ Partials 12 11 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iisa
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
collectionTitlesproperty toSearchResponseDetailsobjects, which optionally contains any collection titles object found on the response. The PPS has recently been upgraded to include such an object on hits/aggregations requests, containing a mapping from any collection identifiers to their readable titles.