Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBDEV-6174 Add models for collection page extra info #37

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Jun 29, 2023

The PPS now provides collection_extra_info for collection_details requests, and will soon allow multiple hit types to be included in a single response. This PR updates the search service models to accommodate the new response changes.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-11 22:18 UTC

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #37 (b3d4f41) into main (7174c57) will increase coverage by 0.03%.
The diff coverage is 87.50%.

❗ Current head b3d4f41 differs from pull request most recent head 97c481a. Consider uploading reports for the commit 97c481a to get more accurate results

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   92.10%   92.13%   +0.03%     
==========================================
  Files          26       26              
  Lines        2532     2544      +12     
  Branches      224      225       +1     
==========================================
+ Hits         2332     2344      +12     
  Misses        189      189              
  Partials       11       11              
Impacted Files Coverage Δ
src/responses/search-response-details.ts 95.12% <87.50%> (+0.52%) ⬆️

Copy link
Contributor

@iisa iisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

test/responses/search-response-details.test.ts Outdated Show resolved Hide resolved
@latonv latonv merged commit 782b929 into main Jul 11, 2023
2 checks passed
@latonv latonv deleted the webdev6174-collection-extra-info branch July 11, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants