-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow search-service to handle new hits type "favorited_search" #41
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hit type addition!
Noted some testing changes that block merge. Otherwise LGTM aside from a couple of minor Qs/suggestions.
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 92.19% 91.43% -0.76%
==========================================
Files 26 27 +1
Lines 2561 2661 +100
Branches 225 232 +7
==========================================
+ Hits 2361 2433 +72
- Misses 189 217 +28
Partials 11 11
|
https://webarchive.jira.com/browse/WEBDEV-6341