Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow search-service to handle new hits type "favorited_search" #41

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

nsharma123
Copy link
Contributor

@nsharma123 nsharma123 changed the title Added favorited_search hit-type Allow search-service to handle new hits type "favorited_search" Aug 18, 2023
@github-actions
Copy link

github-actions bot commented Aug 18, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-08-23 07:54 UTC

Copy link
Contributor

@latonv latonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hit type addition!

Noted some testing changes that block merge. Otherwise LGTM aside from a couple of minor Qs/suggestions.

src/models/hit-types/hit.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
src/search-backend/base-search-backend.ts Outdated Show resolved Hide resolved
src/models/hit-types/favorited_search-hit.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #41 (50df71b) into main (a61f011) will decrease coverage by 0.76%.
Report is 1 commits behind head on main.
The diff coverage is 72.00%.

❗ Current head 50df71b differs from pull request most recent head 7c90f9c. Consider uploading reports for the commit 7c90f9c to get more accurate results

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   92.19%   91.43%   -0.76%     
==========================================
  Files          26       27       +1     
  Lines        2561     2661     +100     
  Branches      225      232       +7     
==========================================
+ Hits         2361     2433      +72     
- Misses        189      217      +28     
  Partials       11       11              
Files Changed Coverage Δ
src/responses/search-response-details.ts 93.65% <33.33%> (-1.48%) ⬇️
src/models/hit-types/favorited-search-hit.ts 71.01% <71.01%> (ø)
src/models/metadata.ts 77.93% <78.57%> (+0.03%) ⬆️

@nsharma123 nsharma123 merged commit f52735d into main Aug 23, 2023
2 checks passed
@nsharma123 nsharma123 deleted the support-favorited-search-hit-type branch August 23, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants