Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBDEV-6399 Legacy caching params #44

Merged
merged 3 commits into from
Nov 10, 2023
Merged

WEBDEV-6399 Legacy caching params #44

merged 3 commits into from
Nov 10, 2023

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Oct 5, 2023

Permits legacy-style caching params to be used on Offshoot pages (reCache, noCache, and the new dontCache), and aliases the cacheDebug param to have the behavior as debugging.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-10 01:32 UTC

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #44 (99da2c3) into main (937e063) will decrease coverage by 0.03%.
The diff coverage is 91.89%.

❗ Current head 99da2c3 differs from pull request most recent head 09f342d. Consider uploading reports for the commit 09f342d to get more accurate results

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   91.43%   91.40%   -0.03%     
==========================================
  Files          27       27              
  Lines        2661     2688      +27     
  Branches      232      235       +3     
==========================================
+ Hits         2433     2457      +24     
- Misses        217      220       +3     
  Partials       11       11              
Files Coverage Δ
src/search-backend/base-search-backend.ts 88.80% <91.89%> (+0.01%) ⬆️

Copy link
Contributor

@iisa iisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests!

@latonv latonv merged commit 56d2952 into main Nov 10, 2023
2 checks passed
@latonv latonv deleted the webdev6399-cache-params branch November 10, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants