-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEBDEV-6081 Extend models for profile pages #48
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 91.40% 92.27% +0.87%
==========================================
Files 27 29 +2
Lines 2688 3095 +407
Branches 235 271 +36
==========================================
+ Hits 2457 2856 +399
- Misses 220 230 +10
+ Partials 11 9 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, had some questions, comments.
q: do we need a page_elements
test?
This MR equips the search service with several new models to handle profile page requests & responses from the PPS. In particular, clients can now request specific
page_elements
, corresponding roughly to tabs on the profile page. The responses can now accordingly include their main content on apage_elements
branch whose shape is determined in part by the type of page element being returned.This necessarily includes some additional refactoring to cleanly handle what are now multiple page-element-specific means by which search hits must be processed to provide the caller with as consistent an output as possible.