Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Search Request Params #7

Merged
merged 8 commits into from
May 2, 2022
Merged

Simplify Search Request Params #7

merged 8 commits into from
May 2, 2022

Conversation

jbuckner
Copy link
Contributor

@jbuckner jbuckner commented Feb 17, 2022

Instead of having to instantiate classes for searches, now you can just pass JSON objects in.

@jbuckner jbuckner changed the title WIP: Simplifying search and initialization options WIP: Simplify search and initialization options Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #7 (27a1169) into main (8b465af) will decrease coverage by 4.06%.
The diff coverage is 69.71%.

❗ Current head 27a1169 differs from pull request most recent head 554c5ac. Consider uploading reports for the commit 554c5ac to get more accurate results

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   79.60%   75.54%   -4.07%     
==========================================
  Files          20       20              
  Lines        1329     1325       -4     
  Branches       32       26       -6     
==========================================
- Hits         1058     1001      -57     
- Misses        269      322      +53     
  Partials        2        2              
Impacted Files Coverage Δ
src/models/file.ts 58.09% <36.23%> (-36.97%) ⬇️
src/models/review.ts 51.21% <44.11%> (-15.45%) ⬇️
src/search-backend/default-search-backend.ts 89.58% <100.00%> (+1.03%) ⬆️
src/search-param-url-generator.ts 100.00% <100.00%> (ø)
src/search-params.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59342f...554c5ac. Read the comment docs.

@jbuckner jbuckner changed the title WIP: Simplify search and initialization options Simplify Search Request Params May 2, 2022
@jbuckner jbuckner merged commit e4fb359 into main May 2, 2022
@jbuckner jbuckner deleted the convert-to-interfaces branch May 2, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant