Check track before sending to youtube wrapper or spotify #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneriley
reviewed
Jul 19, 2019
| audioSource = find(tracklistToShow, track => track.trackNumber === trackToHighlight); | ||
|
|
||
| // If selected track not null find info for selcted track, else find for first track of list of selected channel | ||
| audioSource = trackSelected ? tracklistToShow.find(t => t.trackNumber === trackSelected) : tracklistToShow.find(t => t.trackNumber >= 1); |
There was a problem hiding this comment.
I'm curious what happens when a CD is presented with a track number of 0. This album, for example, ripped the media before the first track marker as "Hidden track one audio". With this change wouldn't the player always skip that 0th track?
There was a problem hiding this comment.
In this case track 0 is actually assigned the trackNumber 1 (and we're only depending on trackNumber to decide the track to be loaded)
track 0
track 1
shaneriley
approved these changes
Jul 19, 2019
iisa
reviewed
Jul 19, 2019
...ages/ia-components/sandbox/theatres/with-youtube-spotify/audio-with-youtube-spotify-main.jsx
Show resolved
Hide resolved
iisa
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #230
Verifies a track number's presence in the youtube/spotify channel before sending it to their respective wrapper, if not present sends the next track in order.