Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the default list of SSL ciphers of python
ssl
module when we connectto remote hosts. That list is probably outdated.
https://github.com/python/cpython/blob/3.6/Lib/ssl.py#L192
We noticed problems when connection to various targets. E.g.
Research indicated that the cipher selection is not proper.
I use
urllib3
cipher selection for better compatibility.https://github.com/shazow/urllib3/blob/master/urllib3/util/ssl_.py#L71
The
urllib3
list is bigger and includes TLS13 which from my experienceis the latest state of the art.
ssl
module ciphers:urllib3
module ciphers: