Refactoring CDXServer processor code for coming extension of CDX #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat and field interpretation change. CDXLineFactory and FieldSplitFormat are encapsulated in new interface CDXFormat, with which revisit detection can be customized. Processor constructor signature has changed. modifyOutputFormat behavior has changed (now it must add fields before calling downstream). There should be no change to external behavior, except for CDXServer.cdxFormat property whose type has changed from String to CDXFormat; it is backward compatible at Spring configuration level thanks to property editor for CDXFormat. As a side effect, resolveRevisit bug is fixed (WWM-978).
kngenie
changed the title
|
Nothing reported from our merge into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format and field interpretation change -- we are adding more fields to CDX and also changing how revisit records are represented in CDX line. This change will allow us to make that change without affecting other deployment using traditional CDX11/CDX9.
There should be no change to external behavior, except for
CDXServer.cdxFormatproperty whose type has changed fromStringtoCDXFormat;it is backward compatible at Spring configuration level thanks to property editor for
CDXFormat.CDXLineFactoryandFieldSplitFormatare encapsulated in new interfaceCDXFormat, through which revisit detection can be customized.CDXLine Processor constructor signature has changed.
modifyOutputFormatbehavior has changed (now it must add fields before calling downstream).For any deployment using custom processor, this can be a breaking change (unlikely, I hope)
As a side effect, resolveRevisit bug is fixed (WWM-978).