Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the bot mentions #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

etspaceman
Copy link

@etspaceman etspaceman commented Mar 6, 2024

When I was testing this out, I noticed a couple of things:

  • Bots were not included in the mentions for a message
  • Message Content is a special privilege that needed to be added

Added a section about this in the README and leveraged the message content instead of the mentions.

@internetisgone
Copy link
Owner

internetisgone commented Mar 7, 2024

message content intent is not required in order for the bot to see content of messages that mention it. i think it's good practice to give the bot only the minimal required permissions. interaction was changed from ! command prefix to @ mentions for this very reason c81096a

@etspaceman
Copy link
Author

When I was testing this out on my own servers, mentioning a bot user specifically did not show up in the mentions for a message. So I had to resort to using message content.

We ended up making a new update that leverages a role instead of the user though. That is because it was not possible to restrict the use of the bot for users. Having the bot be a part of a role that is referenced does allow for that. And it shows up in role_mentions. Something to think about with this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants