Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow illuminate/collections ^9.0 support #24

Closed
adrienne opened this issue Aug 17, 2022 · 3 comments
Closed

Allow illuminate/collections ^9.0 support #24

adrienne opened this issue Aug 17, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@adrienne
Copy link

Currently the plugin can't be installed on PHP 8 because of the composer requirement for illuminate/collections -- adding ^9.0 as a possibility will fix the problem.
@internetztube internetztube added the bug Something isn't working label Aug 22, 2022
@internetztube
Copy link
Owner

Which version are you using? In 2.0.0, illuminate/collections is no longer a dependency.
https://github.com/internetztube/craft-element-relations/blob/2.x/composer.json#L24-L26

internetztube added a commit that referenced this issue Aug 27, 2022
@internetztube
Allow illuminate/collections ^9.0 as dependency. #24
4150ac5
@internetztube
Copy link
Owner

internetztube commented Aug 27, 2022 •
edited

I assume you're using 1.x. In 1.3.8 illuminate/collections ^9.0 is now also allowed as a dependency.

@adrienne
Copy link
Author

@internetztube yeah, sorry, 1.x version because we're still on Craft 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrienne @internetztube