Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated display_df and print_list to use isclose for show_only_changes #357

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

bdavj
Copy link
Contributor

@bdavj bdavj commented Mar 16, 2023

Previously, show_only_changes used direct equality, resulting in all values flagging as changed incorrectly.

This change updates CounterfactualExamples to use math.isclose to generate both the lists and displayed dataframes when show_only_changes=True

Previously, show_only_changes used direct equality, resulting in all values flagging as changed incorrectly.

Signed-off-by: Ben J <bdavjones@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (6d4b871) 68.27% compared to head (76d436b) 68.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   68.27%   68.28%           
=======================================
  Files          27       27           
  Lines        3603     3604    +1     
=======================================
+ Hits         2460     2461    +1     
  Misses       1143     1143           
Flag Coverage Δ
unittests 68.28% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dice_ml/diverse_counterfactuals.py 65.54% <33.33%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amit-sharma
Copy link
Collaborator

Thanks for this contribution @bdavj somehow I missed checking this PR.

@amit-sharma amit-sharma merged commit 67e62cd into interpretml:main Sep 9, 2023
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants