Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle scipy failures due to renaming of scipy.sparse modules in v1.8 #6

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

connortann
Copy link
Collaborator

@connortann connortann commented Mar 7, 2024

Fixes the unit tests, and closes #5

Changes:

  • Handle renaming of scipy.sparse submodules in scipy v1.8
  • Slightly more verbose stderr in tests

After this change is in, it would be great to have a release if possible.

Signed-off-by: Connor Tann <71127464+connortann@users.noreply.github.com>
Signed-off-by: Connor Tann <71127464+connortann@users.noreply.github.com>
Signed-off-by: Connor Tann <71127464+connortann@users.noreply.github.com>
@connortann connortann marked this pull request as ready for review March 7, 2024 14:04
@connortann connortann changed the title WIP: fix scipy failures Fix: handle scipy failures due to renaming of scipy.sparse modules in v1.8 Mar 7, 2024
@paulbkoch paulbkoch merged commit cf53c86 into master Mar 9, 2024
6 checks passed
@paulbkoch
Copy link
Contributor

Thanks @connortann -- I'll put out a release out with this.

@paulbkoch paulbkoch deleted the scipy branch March 9, 2024 06:31
@paulbkoch
Copy link
Contributor

v0.0.8 released on PyPI now.

@connortann
Copy link
Collaborator Author

@paulbkoch that's great! Would you be able to make a release on conda-forge as well?

I noticed on the feedstock repo there no auto-update Pull Request. On the current migrations page, it looks like the update to v0.0.8 has hit an error:

https://conda-forge.org/status/#current_migrations

2.00 attempts - The recipe did not change in the version migration, a URL did not hash, or there is jinja2 syntax the bot cannot handle!

Please check the URLs in your recipe with version '0.0.8' to make sure they exist!

We also found the following errors:

 - could not hash URL template 'https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/slicer-{{ version }}.tar.gz'

@paulbkoch
Copy link
Contributor

I'm not an owner of the feedstock repo. I think only Scott is, last I looked.

If you end up getting access, can you also add me as a maintainer of the feedstock in case we take a dependency on slicer in the future for InterpretML.

@paulbkoch
Copy link
Contributor

You know what, I'll ping Scott and ask him.

@paulbkoch
Copy link
Contributor

Pinged Scott and asked him to add both of us @connortann as maintainers of the slicer feedstock.

@paulbkoch
Copy link
Contributor

Hi @connortann -- We're both maintainers for the slicer feedstock now. Do you want to take up the release from there?

@connortann
Copy link
Collaborator Author

Thanks! I'll take a look. I'm admittedly not particularly experienced with conda feedstocks but shall have a go getting the recipe updated.

Talking of maintainers, please do let me know if you'd be interested in becoming a maintainer of shap: shap/shap#3559

@paulbkoch
Copy link
Contributor

Ok, I'll put out a release then. It's kind of a weird system that conda-forge uses, but I'm familiar with it.

@paulbkoch
Copy link
Contributor

Thanks @connortann -- I think I'll pass on being a shap maintainer for now, but I'll let you know if anything changes in the future. I've got my hands pretty full at the moment since I'm still maintaining the interpret repo, and have more recently become involved in Scott's new Guidance project https://github.com/guidance-ai/guidance/

@paulbkoch
Copy link
Contributor

Hi @connortann -- Slicer v0.0.8 is on conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Failing tests: slicing sparse matrices
2 participants