Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swapped Items Rotate Forever #52

Closed
joshuaskelly opened this issue Aug 22, 2020 · 0 comments · Fixed by #61
Closed

Swapped Items Rotate Forever #52

joshuaskelly opened this issue Aug 22, 2020 · 0 comments · Fixed by #61
Assignees
@joshuaskelly
Labels
good first issue Good for newcomers polish Needs cleanup and polish
Milestone
v1.3.0

Comments

@joshuaskelly
Copy link
Collaborator

joshuaskelly commented Aug 22, 2020 •
edited
Loading

item-rotation-bug

Summary

Swapping an inventory with an item on the ground can result in the item on the ground rotating forever.

Repro Steps

This doesn't 100% repro, but can can be reproduced by trying various items.

  1. Swap an item from the ground to an inventory slot that is not an equipped item.

Notes

This seems to come from: Item.java:293
The item for some reason is never set to being on the floor and will alway rotate.

Drag and drop logic lives here: Game.java:1172
@joshuaskelly joshuaskelly added the bug Something isn't working label Aug 22, 2020
@joshuaskelly joshuaskelly self-assigned this Aug 22, 2020
@joshuaskelly joshuaskelly added this to the v1.3.0 milestone Aug 22, 2020
@joshuaskelly joshuaskelly added good first issue Good for newcomers polish Needs cleanup and polish and removed bug Something isn't working labels Aug 22, 2020
@joshuaskelly joshuaskelly mentioned this issue Sep 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaskelly joshuaskelly

Labels
good first issue Good for newcomers polish Needs cleanup and polish
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Fixing infinitely spinning dropped item Interrupt/delverengine
1 participant
@joshuaskelly