Maps lacking tests

[webdev778]

We are in the process of porting the maps to interscript/lcs. The problem is, some maps lack tests. Below is a list of maps and their git history so we can see better who made them and contact them to provide those tests possibly.

alalc-bul-Cyrl-Latn-1997

Alexande B (1):

• Implement system alalc-bul-cyrl-latn-1997 (ALA-LC Romanization Table -- Bulgarian (1997) interscript-ruby#80 Implement system bgnpcgn-bul-cyrl-latn-1952 (BGN/PCGN Romanization System -- Bulgarian (1952) interscript-ruby#81 Implement system bgnpcgn-bul-cyrl-latn-2013 (BGN/PCGN Romanization Agreement -- Bulgarian (2013) interscript-ruby#82 Implement system bgna-bul-cyrl-latn-2006 (Bulgarian National Assembly Romanization 2006) interscript-ruby#83 Implement system odni-bul-cyrl-latn-2005 (Office of the Director Of National Intelligence Bulgarian Personal Names 2004 System interscript-ruby#84 Implement system apcbg-bul-cyrl-latn-1995 (Toponymic Guidelines for Antarctica) interscript-ruby#256 Implement system bgna-bul-cyrl-latn-2009 (Bulgarian National Assembly Romanization 2009) interscript-ruby#257 add Bulgarian more maps

Ronald Tse (2):

• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472
• Add OGC 11-122r1 codes to maps, rename zho “wade giles” to wd-1979

alalc-ukr-Cyrl-Latn-2011

Andrei Kislichenko (1):

• fix issue Implement system alalc-ukr-cyrl-latn-2011 (ALA-LC Romanization Table -- Ukrainian (2011) interscript-ruby#246

Ronald Tse (1):

• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

bgnpcgn-arm-Armn-Latn-1981

Ronald Tse (5):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

bgnpcgn-ell-Grek-Latn-1996

Nick Nicholas (4):

• update
• update
• Add alalc-ell 1997, elot-ell-743-2001, elot-ell-743-1982, un-ell-1987,
• update

Ronald Tse (2):

• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472
• Add OGC 11-122r1 codes to maps, rename zho “wade giles” to wd-1979

webdev778 (1):

• update rename task & map files

bgnpcgn-fas-Arab-Latn-1956

Ronald Tse (4):

• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472
• Add OGC 11-122r1 codes to maps, rename zho “wade giles” to wd-1979

webdev778 (1):

• update rename task & map files

bgnpcgn-zho-Hans-Latn-1979

Ronald Tse (5):

• Add Pinyin map
• Rename system codes according to csd-transcription-systems
• Remove empty tests
• Update bgnpcgn-chn-Hans-Latn-1979 to use correct language code "zho"
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

elot-ell-Grek-Latn-743-2001-tl

Nick Nicholas (7):

• update
• update
• update
• update
• update
• filenames
• Add alalc-ell 1997, elot-ell-743-2001, elot-ell-743-1982, un-ell-1987,

Ronald Tse (2):

• Update map descriptions
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

webdev778 (1):

• update rename task & map files

icao-bul-Cyrl-Latn-9303

Ronald Tse (5):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

webdev778 (1):

• update rename task & map files

icao-fas-Arab-Latn-9303

Andrei Kislichenko (1):

• fix issue Enable system definition internal tests interscript-ruby#6

Ronald Tse (5):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

webdev778 (1):

• update rename task & map files

icao-heb-Hebr-Latn-9303

Andrei Kislichenko (1):

• fix issue Enable system definition internal tests interscript-ruby#6

Ronald Tse (5):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

icao-mkd-Cyrl-Latn-9303

Ronald Tse (5):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

icao-rus-Cyrl-Latn-9303

Ronald Tse (7):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Add interscript command (Implement arabic stage to drop diacritics #4)
• Fix whitespacing issue in maps
• Correct chmod for maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

webdev778 (1):

• update rename task & map files

icao-srp-Cyrl-Latn-9303

Ronald Tse (5):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

icao-ukr-Cyrl-Latn-9303

Ronald Tse (5):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Fix whitespacing issue in maps
• Remove empty tests
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

webdev778 (1):

• update rename task & map files

iso-rus-Cyrl-Latn-9-1995

Ronald Tse (8):

• Initial commit
• Update grapheme correspondence maps to provide id, URIs and details
• Add interscript command (Implement arabic stage to drop diacritics #4)
• Fix whitespacing issue in maps
• Rename system codes according to csd-transcription-systems
• Remove empty tests
• Update map descriptions
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

webdev778 (1):

• update rename task & map files

un-ell-Grek-Latn-1987-ts

Nick Nicholas (5):

• update
• update
• filenames
• Add alalc-ell 1997, elot-ell-743-2001, elot-ell-743-1982, un-ell-1987,
• update

Ronald Tse (2):

• Update map descriptions
• Provide namespaces for iso-639-x codes, fixes Differentiate ISO 639 codes from parts 2, 3, 5 interscript-ruby#472

webdev778 (1):

• update rename task & map files

[webdev778]

Some pings: @andrew2net @CAMOBAP @opoudjis

[CAMOBAP]

@webdev778 I always added tests for mappings that contain any samples. In case if there are no samples, I tried to find/google. I decided to not generate the test on my own because this is a bad approach IMHO because if implementation contains bugs/issues we will just 'support' those issues with tests. Let me know if you disagree (I'm open to change my mind).

[webdev778]

@CAMOBAP As far as I can see, there's only 1 map of yours on this list. I used an approach to sometimes generate my own tests based on what's described in the notes. This ensures that the notes are implemented correctly.

[andrew2net]

@webdev778 I've added tests whenever I was able to do it. Unfortunately, I'm not good in all languages for that I've implemented maps (some of the languages I don't know at all). Try to ask @ronaldtse, he had an intention to find experts.

[opoudjis]

• elot-ell-Grek-Latn-743-2001-tl.yaml inherits from iso-ell-Grek-Latn-843-1997-t1: they are identical, so no additional tests are needed.
• bgnpcgn-ell-Grek-Latn-1996.yaml inherits from elot-ell-Grek-Latn-743-1982-ts, ditto
• elot-ell-Grek-Latn-743-2001-tl.yaml inherits from iso-ell-Grek-Latn-843-1997-t1, ditto
• un-ell-Grek-Latn-1987-ts.yaml inherits from elot-ell-Grek-Latn-743-1982-ts, ditto

If you do need tests, just copy paste them from the parent mappings.

[ronaldtse]

If you do need tests, just copy paste them from the parent mappings.

@webdev778 can you help copy those tests for the Greek maps? Thanks.

if implementation contains bugs/issues we will just 'support' those issues with tests. Let me know if you disagree (I'm open to change my mind).

@CAMOBAP still we would like to encode some tests because we are switching to a new language mapping approach, we need to ensure the new output is identical to old output.

icao-fas-Arab-Latn-9303
@AhMohsen46 can you help create the tests?

icao-rus-Cyrl-Latn-9303
@CAMOBAP can you do this?

icao-ukr-Cyrl-Latn-9303
alalc-ukr-Cyrl-Latn-2011
@ni4 would you be able to help?

icao-mkd-Cyrl-Latn-9303
icao-srp-Cyrl-Latn-9303
@andrew2net I believe you can make tests for these?

[ni4]

@ronaldtse Sure. At first glance icao-ukr-Cyrl-Latn-9303 has some extra symbols, which are not present in Ukrainian, and doesn't include some rules (like, when some letter is first in the word then it is transliterated with 2 symbols instead of 1). I assume that I should fix these things as well?

[AhMohsen46]

working on this: icao-fas-Arab-Latn-9303 now, will push it in an hour at max