refactor: use date as model for date picker #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
enhancement
dhhyi
force-pushed
the
refactor/use-date-for-datepicker
branch
from
da2b66d
to
cac0ff2
Compare
dhhyi
force-pushed
the
refactor/use-date-for-datepicker
branch
from
cac0ff2
to
2cb0ab5
Compare
dhhyi
commented
May 2, 2022
| @@ -82,11 +84,11 @@ export class BasketDesiredDeliveryDateComponent implements OnInit, OnChanges { | |||
| } | |||
|
|
|||
| ngOnChanges(changes: SimpleChanges) { | |||
| const previous = this.getDesiredDeliveryDate(changes.basket?.previousValue); | |||
| const current = this.getDesiredDeliveryDate(changes.basket?.currentValue); | |||
|
|
|||
| // we only care about the ddd, so only do anything if it has changed | |||
There was a problem hiding this comment.
I thougth ddd was a typo 😅
MaxKless
approved these changes
May 2, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: max.kless@googlemail.com <max.kless@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
The date pickers use a fixed formatted string as model. If any follow up wants to do something with the date, it has to be parsed again.
What Is the New Behavior?
NgbDateNativeAdapter.DateHelperdissolved and methods fromDate,NgbCalendaranddate-fnsare used directly.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#76130