feat(seo): optimized category URLs with full category path #1163
Conversation
There was a problem hiding this comment.
@Eisie96 Is there anything that speaks against including the path categories into the CategoryView model? That way you wouldn't need an additional store selector and additional arguments to the functions... 🤔
EDIT 1: I originally removed that in #284 as part of a memoization optimization (getting rid of the functions), and I think the pathCategories were no longer required as CategoryView at that time, but at the moment I see no reason to re-add them like that in a properly memoized way.
EDIT 2: With the extension of the view, you can also simplify things in #1164
|
@dhhyi Thank you for your review. It is a really good idea to put the category path to the category view! The CategoryRoutePipe is now a pure function. One thing i have to change would be the getCategory(uniqueId) selector. It generates the category view with the subtree of the given uniqueid. But the whole tree is necessary to get all elements from the category path. |
Eisie96
force-pushed
the
refactor/improve-category-url
branch
from
2ca51c2
to
86d7e5d
Compare
Eisie96
force-pushed
the
refactor/improve-category-url
branch
2 times, most recently
from
55076e1
to
9f9b456
Compare
shauke
force-pushed
the
refactor/improve-category-url
branch
4 times, most recently
from
96e1879
to
7367d1e
Compare
* changed category id marker from 'cat' to 'ctg' * unified base for SEO route generation
shauke
force-pushed
the
refactor/improve-category-url
branch
from
7367d1e
to
dc6f236
Compare
shauke
changed the title
* changed category id marker from 'cat' to 'ctg' * unified base for SEO route generation BREAKING CHANGES: Changed category routes/URLs (see [Migrations / 2.4 to 3.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#24-to-30) for more details).
shauke
force-pushed
the
refactor/improve-category-url
branch
from
dc6f236
to
bd25b16
Compare
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Behavior?
The current category url contains only the current category displayname with an appended categoryUniqueId. (/Acer-Sub-catComputers.897.897_Acer.Acer-Sub)
This needs to be improved for SEO. Every category page should contain the whole path from the top level to the requested category. Only display-names should be used. The needed categoryUniqueId to get the data from the ICM should be at the end of the url. (/acer/sub/acer-sub-catComputers.897.897_Acer.Acer-Sub)
Does this PR Introduce a Breaking Change?
[x] Yes
Other Information
AB#76756