feat: added comments regarding logging to an external device. #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
previously approved these changes
Apr 20, 2023
shauke
force-pushed
the
feature/enable-logging-from-docker-based-pwa-nginx-and-ssr-containers
branch
from
e5770aa
to
044df56
Compare
…le to the actual logging documentation * logging documentation improvement/restructuring * additional docker-compose.yml cleanup
shauke
force-pushed
the
feature/enable-logging-from-docker-based-pwa-nginx-and-ssr-containers
branch
from
044df56
to
f3c8262
Compare
shauke
approved these changes
Apr 25, 2023
shauke
deleted the
feature/enable-logging-from-docker-based-pwa-nginx-and-ssr-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[x] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
Other Information
This pull request addresses writing logs to local directories by enabling volumes, as discussed on 19.04.2023.
Please clarify if the example paths should stay as they are, or if we should rather add placeholders.
Also see Confluence article: "Support Article - Enable Logging from Docker-based PWA NGINX and SSR Containers" (not linked here since it is not public yet)
AB#85477