fix: adapt 'addGlobalGuard' function to work with functional guards #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* needed to fix Hybrid Approach to successfully register 'hybridRedirectGuard'
SGrueber
previously approved these changes
Apr 28, 2023
|
Are you sure the check for 'guard.prototype.canActivate' is not needed any more? |
SGrueber
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
The changes for "refactor(Angular 15): replace class-based route guards by functional guards" (289e161) broke the registration of the global
hybridRedirectGuardneeded for the Hybrid Approach. So the Hybrid Approach is not working with PWA 4.0.0.What Is the New Behavior?
The global guard registration works again and the Hybrid Approach can be used with current PWA versions again.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#85701