Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OCI punchout configuration #1431

Merged
merged 20 commits into from Jun 2, 2023

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented May 15, 2023

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the New Behavior?

There is a new page to configure the OCI punchout.

Formatters are not translated, this will be fixed in the next ICM version.
There is only a client side validation for mapping from/to values. All other validations are done by the server and the response error is shown as error message.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#86061

@SGrueber SGrueber requested a review from Eisie96 May 17, 2023 08:37
@SGrueber SGrueber self-assigned this May 17, 2023
@SGrueber SGrueber added enhancement Enhancement to an existing feature feature New feature or request labels May 17, 2023
@SGrueber SGrueber added this to the 4.1 milestone May 17, 2023
@github-actions
Copy link

Azure Demo Servers are available:

@SGrueber SGrueber force-pushed the feature/oci_punchout_configuration_ui branch from 38e1ddc to dea3bb9 Compare May 17, 2023 09:29
@github-actions
Copy link

Azure Demo Servers are available:

iwiederhold
iwiederhold previously approved these changes May 17, 2023
@iwiederhold iwiederhold self-requested a review May 17, 2023 14:35
schadii
schadii previously approved these changes May 17, 2023
@schadii schadii self-requested a review May 17, 2023 15:16
@Eisie96 Eisie96 dismissed stale reviews from schadii and iwiederhold via f39052e May 25, 2023 07:36
@SGrueber SGrueber requested review from Eisie96 and marschmidt89 and removed request for iwiederhold, marschmidt89, Eisie96 and schadii June 1, 2023 11:08
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Azure Demo Servers are available:

@iwiederhold
Copy link

Is it possible to align the button row?
align_button

@SGrueber
Copy link
Collaborator Author

SGrueber commented Jun 1, 2023

@iwiederhold Yes. I'll do that

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Azure Demo Servers are available:

@iwiederhold
Copy link

THX!

SGrueber and others added 20 commits June 2, 2023 11:19
(cherry picked from commit 7d69abc)
…ffect, seperate configuration selectors to have better memoization
@SGrueber SGrueber force-pushed the feature/oci_punchout_configuration_ui branch from 3b17b40 to e2c8591 Compare June 2, 2023 09:45
Copy link
Contributor

@marschmidt89 marschmidt89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l10n for DE, EN approved, FR will be checked later.

@schadii schadii requested a review from iwiederhold June 2, 2023 14:09
@SGrueber SGrueber merged commit dfc19ac into develop Jun 2, 2023
23 checks passed
@SGrueber SGrueber deleted the feature/oci_punchout_configuration_ui branch June 2, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants