fix: NoSunday date validator does not work properly #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for sunday, it's not working due to wrong check.
|
@kp7860 Thanks for this bugfix. Is there any reason why this pull request is draft? Can we merge it? |
SGrueber
changed the title
SGrueber
changed the title
SGrueber
approved these changes
Jul 7, 2023
|
@SGrueber I am not able to merge the request. Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
The date validator noSunday is supposed to check a date input field to be not a Sunday, but the check is not working.
Issue Number: Closes #
What Is the New Behavior?
The date validator works as expected.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information