Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair partial build after npm upgrade #1476

Merged
merged 1 commit into from Aug 11, 2023
Merged

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Aug 10, 2023

PR Type

[x] Bugfix
[x] Build-related changes

What Is the Current Behavior?

After npm upgrade, the command npm config set active-themes does no longer work for a partial build in the Dockerfile.
Test by uncommenting the build args of the SSR image activeThemes: b2c in the docker-compose.yml:

pwa:
build:
context: .
args:
serviceWorker: 'false'
# activeThemes: b2b
# activeThemes: b2c

What Is the New Behavior?

Using npm pkg set config.active-themes to modify the package.json in the Dockerfile when building.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#88442

@dhhyi dhhyi added the bug Something isn't working label Aug 10, 2023
@dhhyi dhhyi self-assigned this Aug 10, 2023
@dhhyi dhhyi marked this pull request as ready for review August 11, 2023 04:51
@dhhyi dhhyi requested a review from shauke August 11, 2023 04:52
@dhhyi dhhyi removed their assignment Aug 11, 2023
@dhhyi dhhyi added the regression Something previously working doesn't work anymore label Aug 11, 2023
@shauke shauke added this to the 4.2 milestone Aug 11, 2023
@shauke shauke merged commit 30cc36c into develop Aug 11, 2023
24 checks passed
@shauke shauke deleted the fix/partial-build branch August 11, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something previously working doesn't work anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants