Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use better suited operators for REST requests #1491

Merged
merged 2 commits into from Aug 25, 2023

Conversation

Eisie96
Copy link
Contributor

@Eisie96 Eisie96 commented Aug 23, 2023

PR Type

[ x ] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

NGRX Effects are one of the core functionality of the PWA. It uses different actions, where the business logic is written with rxjs methods and operators. When the concatMap() operator is used, then each new subscriptions to a new observable has to wait until the previous is completed. This can lead to the problem, that http request are send sequentially although it could be done in parallel. Mainly loading actions

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#88843

@Eisie96 Eisie96 self-assigned this Aug 24, 2023
@shauke shauke marked this pull request as ready for review August 25, 2023 07:12
@shauke shauke added this to the 4.2 milestone Aug 25, 2023
@shauke shauke changed the title Refactor/operator improvement effects perf: use better suited operators for REST requests Aug 25, 2023
@shauke shauke merged commit e54f611 into develop Aug 25, 2023
26 checks passed
@shauke shauke deleted the refactor/operator-improvement-effects branch August 25, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants