Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent setting values on uninitialized field #1492

Merged
merged 1 commit into from Sep 5, 2023

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Aug 29, 2023

PR Type

[x] Bugfix

What Is the Current Behavior?

While doing load tests I observed the following errors:

5 b2c ERROR TypeError Cannot read properties of undefined (reading 'length') at templateFn (/dist/b2c/server/webpack:/src/app/shared/cms/components/cms-carousel/cms-carousel.component.html:6:23)
5 b2c
5 b2c /dist/b2c/server/webpack:/src/app/shared/cms/components/cms-carousel/cms-carousel.component.ts:55
          this.carousel.interval = val;
                        ^
5 b2c TypeError: Cannot set properties of undefined (setting 'interval')
    at Object.next (/dist/b2c/server/webpack:/src/app/shared/cms/components/cms-carousel/cms-carousel.component.ts:55:25)
    at ConsumerObserver2.next (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/Subscriber.js:113:33)
    at SafeSubscriber2._next (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/Subscriber.js:80:26)
    at SafeSubscriber2.next (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/Subscriber.js:51:18)
    at onNext (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/operators/take.js:15:32)
    at OperatorSubscriber2._next (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/operators/OperatorSubscriber.js:33:21)
    at OperatorSubscriber2.next (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/Subscriber.js:51:18)
    at onNext (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/operators/map.js:10:24)
    at OperatorSubscriber2._next (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/operators/OperatorSubscriber.js:33:21)
    at OperatorSubscriber2.Subscriber2.next (/dist/b2c/server/webpack:/node_modules/rxjs/dist/cjs/internal/Subscriber.js:51:18)

What Is the New Behavior?

  • checks added
  • cycle start disabled for SSR

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#88948

@dhhyi dhhyi added the bug Something isn't working label Aug 29, 2023
@dhhyi dhhyi requested a review from shauke August 29, 2023 09:10
@dhhyi dhhyi self-assigned this Aug 29, 2023
@dhhyi dhhyi marked this pull request as ready for review September 5, 2023 08:36
@dhhyi dhhyi removed their assignment Sep 5, 2023
@shauke shauke added this to the 4.2 milestone Sep 5, 2023
@shauke shauke merged commit 8d3f6a1 into develop Sep 5, 2023
23 checks passed
@shauke shauke deleted the fix/cms-carousel-errors branch September 5, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants