Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce product price call aggregation delay #1493

Merged
merged 1 commit into from Sep 6, 2023

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Aug 29, 2023

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[x] Other: Performance Improvement

What Is the Current Behavior?

Every product-related page takes significantly longer to render in SSR mode than other pages.

What Is the New Behavior?

Reduced price window debouncing for SSR.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#89001

@dhhyi dhhyi added the performance Performance improvements label Aug 29, 2023
@dhhyi dhhyi self-assigned this Aug 29, 2023
@dhhyi dhhyi marked this pull request as ready for review September 5, 2023 08:27
@dhhyi dhhyi removed their assignment Sep 5, 2023
@dhhyi dhhyi requested a review from Eisie96 September 5, 2023 12:09
@shauke shauke added this to the 4.2 milestone Sep 5, 2023
@shauke shauke merged commit 2c10245 into develop Sep 6, 2023
24 checks passed
@shauke shauke deleted the perf/reduce-price-call-delay branch September 6, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants