Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward proto from reverse proxy #1524

Merged
merged 1 commit into from Nov 13, 2023
Merged

fix: forward proto from reverse proxy #1524

merged 1 commit into from Nov 13, 2023

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Oct 20, 2023

PR Type

[x] Bugfix

What Is the Current Behavior?

The protocol used on the topmost reverse proxy is not correctly forwarded to the SSR container.

Steps to reproduce:

  1. Install Intershop Helm Charts:

    helm repo add intershop https://intershop.github.io/helm-charts
    helm repo update
  2. create minimal values.yaml file for proxying ICM:

    environment:
      - name: PROXY_ICM
        value: "true"
      # needed for SSR as ICM certificate is only valid for *.test.intershop.de
      - name: TRUST_ICM
        value: "true"
    
    # needed for using local images instead of always pulling from docker hub
    # image:
    #   pullPolicy: IfNotPresent
    # cache:
    #   image:
    #     pullPolicy: IfNotPresent
  3. Install release:

    helm install dev-release intershop/pwa-main -f values.yaml
  4. Forward pwa.example.local to 127.0.0.1 in your hosts file

  5. Check the release https://pwa.example.local and observe you are getting mixed content errors

What Is the New Behavior?

The protocol is correctly forwarded to the SSR container using and trusting the X-Forwarded-Proto header.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#90392

@dhhyi dhhyi self-assigned this Oct 20, 2023
@dhhyi dhhyi added the bug Something isn't working label Oct 20, 2023
@dhhyi dhhyi marked this pull request as ready for review October 20, 2023 09:04
@dhhyi dhhyi requested a review from shauke October 20, 2023 09:04
@shauke shauke added this to the 5.0 milestone Nov 8, 2023
@shauke shauke merged commit eca77f9 into develop Nov 13, 2023
26 checks passed
@shauke shauke deleted the fix/forward-proto branch November 13, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants