refactor: use server setting for message-to-merchant checkout field #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/use-server-setting-for-messagetomerchant
branch
from
67d94b4
to
8bc8ac4
Compare
|
With this PR the feature is no longer working for ICM 7.10 customers. We can either deprecate the feature in the PWA 5.0 and merge it later or provide the suggested interceptor. |
Base automatically changed from
refactor/typed-environment-feature-toggles
to
develop
January 26, 2024 16:09
shauke
force-pushed
the
refactor/use-server-setting-for-messagetomerchant
branch
from
8bc8ac4
to
a44f30b
Compare
shauke
pushed a commit
that referenced
this pull request
Jan 29, 2024
…1542) BREAKING CHANGES: Removed `messageToMerchant` feature toggle since the feature is controlled via back office configuration in ICM 11 (see [Migrations / From 5.0 to 5.1](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51) for more details and ICM 7.10 compatibility).
shauke
added a commit
that referenced
this pull request
Jan 29, 2024
* can be used for `messageToMerchant` feature toggle compatibility with ICM 7.10 * see https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51 Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
refactor/use-server-setting-for-messagetomerchant
branch
from
a44f30b
to
b282cfd
Compare
shauke
added a commit
that referenced
this pull request
Jan 29, 2024
* can be used for `messageToMerchant` feature toggle compatibility with ICM 7.10 * see https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51 Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
refactor/use-server-setting-for-messagetomerchant
branch
from
b282cfd
to
47452a9
Compare
shauke
added a commit
that referenced
this pull request
Jan 29, 2024
* can be used for `messageToMerchant` feature toggle compatibility with ICM 7.10 * see https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51 Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
refactor/use-server-setting-for-messagetomerchant
branch
from
47452a9
to
8a5257d
Compare
shauke
approved these changes
Jan 29, 2024
SGrueber
approved these changes
Jan 30, 2024
BREAKING CHANGES: Removed `messageToMerchant` feature toggle since the feature is controlled via back office configuration in ICM 11 (see [Migrations / From 5.0 to 5.1](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51) for more details and ICM 7.10 compatibility).
* can be used for `messageToMerchant` feature toggle compatibility with ICM 7.10 * see https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51 Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
shauke
force-pushed
the
refactor/use-server-setting-for-messagetomerchant
branch
from
8a5257d
to
dbb0ca4
Compare
shauke
pushed a commit
that referenced
this pull request
Jan 30, 2024
BREAKING CHANGES: Removed `messageToMerchant` feature toggle since the feature is controlled via back office configuration in ICM 11 (see [Migrations / From 5.0 to 5.1](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51) for more details and ICM 7.10 compatibility).
shauke
added a commit
that referenced
this pull request
Jan 31, 2024
* can be used for `messageToMerchant` feature toggle compatibility with ICM 7.10 * see https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51 Co-authored-by: Stefan Hauke <s.hauke@intershop.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the New Behavior?
In ICM 11
messageToMerchantis a flag supplied by theconfigurationscall, so the according feature toggle is replaced.For compatibility with ICM 7.10 an
ICMCompatibilityInterceptoris provided that can be used to simulate the old behavior where the feature is controlled by a configured feature toggle (see the migration guide for further explanation https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#from-50-to-51).Does this PR Introduce a Breaking Change?
[x] Yes
Other Information
requires ICM 11.5 or higher
AB#93333