fix: use take instead of first to prevent EmptyError on missing translation #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
When translations are missing in both current and fallback language, the
FallbackMissingTranslationHandlerthrowsEmptyErrors.Steps to reproduce:
quickorder.page.linkin both en_US and de_DE localization files.Actual:
and
EmptyErrorin console.Expected:
What Is the New Behavior?
Replaced all
firstwithtake(1)as this could happen with other sources, too.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#92108