Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: order list filtering #1571

Merged
merged 31 commits into from Mar 27, 2024
Merged

feat: order list filtering #1571

merged 31 commits into from Mar 27, 2024

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jan 10, 2024 •
edited by shauke

PR Type

[x] Feature

What Is the New Behavior?

Order List supports filtering by date range, product ID and order number.
If the number of orders exceeds the search result limit (=30) a 'load more' button is shown to fetch more orders from the server.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

Requires ICM 11.7

AB#92680

@dhhyi dhhyi added the feature New feature or request label Jan 10, 2024
@dhhyi dhhyi self-assigned this Jan 10, 2024
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@dhhyi dhhyi force-pushed the feat/order-list-filtering branch 2 times, most recently from 4af9b16 to 4a8e019 Compare January 10, 2024 14:00
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@dhhyi dhhyi requested a review from SGrueber January 11, 2024 11:39
@dhhyi dhhyi removed their assignment Jan 11, 2024
@dhhyi dhhyi marked this pull request as ready for review January 11, 2024 11:39
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@DilaraGueler DilaraGueler requested a review from a team March 5, 2024 15:17
@mglatter
Copy link
Contributor

FR translation for added key will follow

@DilaraGueler
Copy link
Contributor

Hi Dilara, the filters differ slightly from the IAD. Is the Order Status filter not displayed?

Hi Inken, we had to remove the Order Status handling as long as it is not coming from ICM. If this is possible in the future, this part may be added.

@schadii
Copy link

schadii commented Mar 15, 2024

Hi, would you mind considering keeping the filters after clicking on 'find order'? This way, users can easily see the filters they've applied and clear them if they wish.

mglatter
mglatter reviewed Mar 15, 2024
View reviewed changes
src/assets/i18n/de_DE.json Outdated
@@ -153,6 +153,7 @@
"account.customer.registered.title": "Vielen Dank für Ihre Registrierung!",
"account.date.month": "Monat",
"account.date.month.error.required": "Bitte wählen Sie einen Monat aus.",
"account.date.title": "Ein Datum wählen",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if the translation with infinitive form is fine for this title. We did the same for French. Please inform C3PO if any changes are needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@intershop/c3po-documentation-l10n 'Wählen Sie ein Datum aus' would probably be better at this point

mglatter
mglatter previously approved these changes Mar 15, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

schadii
schadii previously approved these changes Mar 18, 2024
View reviewed changes
iwiederhold
iwiederhold previously approved these changes Mar 18, 2024
View reviewed changes
Copy link

@iwiederhold iwiederhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX!

@mglatter mglatter dismissed stale reviews from iwiederhold and schadii via cd719e2 March 18, 2024 14:39
mglatter
mglatter previously approved these changes Mar 18, 2024
View reviewed changes
mglatter
mglatter previously approved these changes Mar 26, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Azure Demo Servers are available:

@shauke shauke merged commit 564d5c8 into develop Mar 27, 2024
24 checks passed
@shauke shauke deleted the feat/order-list-filtering branch March 27, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilaraGueler DilaraGueler DilaraGueler left review comments

@SGrueber SGrueber SGrueber approved these changes

@iwiederhold iwiederhold iwiederhold left review comments

@mglatter mglatter mglatter left review comments

@schadii schadii schadii left review comments

Assignees

@DilaraGueler DilaraGueler

Labels
feature New feature or request
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dhhyi @DilaraGueler @iwiederhold @M-Behr @mglatter @schadii @SGrueber @shauke