Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default search input field specific elements in Chrome #1589

Merged
merged 2 commits into from Feb 23, 2024

Conversation

andreassteinmann
Copy link
Collaborator

@andreassteinmann andreassteinmann commented Feb 22, 2024

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Google Chrome is showing a small "x" inside the search input field <input type="search"> when the user enters anything in the field. The field is shown in the header and on the "No search result" page. This element should be removed because there is already "x" as an icon to remove the user input.

What Is the New Behavior?

The Chrome default "x" is removed. Other default Chrome styling and elements for this specific field are removed too.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

AB#94200

@andreassteinmann andreassteinmann self-assigned this Feb 22, 2024
@SGrueber SGrueber self-requested a review February 22, 2024 10:32
@SGrueber SGrueber added this to the 5.1 milestone Feb 22, 2024
@SGrueber SGrueber force-pushed the fix/x-inside-search-input-chrome branch from 1d07792 to 2255c03 Compare February 22, 2024 16:13
@SGrueber SGrueber merged commit 1903d09 into develop Feb 23, 2024
21 checks passed
@SGrueber SGrueber deleted the fix/x-inside-search-input-chrome branch February 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants