Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use brotli instead of gzip for compression in NGINX #1593

Merged
merged 19 commits into from Mar 20, 2024

Conversation

andreassteinmann
Copy link
Collaborator

@andreassteinmann andreassteinmann commented Mar 1, 2024

PR Type

[x] Feature

What Is the Current Behavior?

gzip is used to compress files on NGINX.

What Is the New Behavior?

ngx_brotli is used to compress files on NGINX because Brotli has a better compression ratio compared to gzip.
Two new NGINX modules ngx_http_brotli_filter_module.so (compressing responses on-the-fly) and ngx_http_brotli_static_module.so (serving pre-compressed files) are built in the Dockerfile and referenced in nginx.conf.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#94548

@andreassteinmann andreassteinmann self-assigned this Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

Azure Demo Servers are available:

3 similar comments
Copy link

github-actions bot commented Mar 5, 2024

Azure Demo Servers are available:

Copy link

github-actions bot commented Mar 6, 2024

Azure Demo Servers are available:

Copy link

github-actions bot commented Mar 6, 2024

Azure Demo Servers are available:

Copy link

github-actions bot commented Mar 7, 2024

Azure Demo Servers are available:

4 similar comments
Copy link

Azure Demo Servers are available:

Copy link

Azure Demo Servers are available:

Copy link

Azure Demo Servers are available:

Copy link

Azure Demo Servers are available:

@shauke shauke changed the title chore: use brotli instead of gzip in nginx feat: use brotli instead of gzip in nginx Mar 12, 2024
@shauke shauke changed the title feat: use brotli instead of gzip in nginx feat: use brotli instead of gzip for compression in NGINX Mar 12, 2024
@shauke shauke added this to the 5.1 milestone Mar 14, 2024
Copy link

Azure Demo Servers are available:

@shauke shauke linked an issue Mar 14, 2024 that may be closed by this pull request
shauke
shauke previously approved these changes Mar 15, 2024
@shauke shauke requested a review from a team March 15, 2024 09:58
@shauke
Copy link
Member

shauke commented Mar 15, 2024

@intershop/c3po-documentation-l10n can you please review the documentation parts, since a bigger part documentation was added

docs/guides/migrations.md Outdated Show resolved Hide resolved
mglatter
mglatter previously approved these changes Mar 19, 2024
Co-authored-by: MGlatter <m.glatter@intershop.de>
@shauke shauke merged commit a9c5766 into develop Mar 20, 2024
17 of 18 checks passed
@shauke shauke deleted the explore/brotli branch March 20, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Brotli compression
3 participants