fix: wrong scrolling behavior #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the scroll behavior of the basket validation results component has been simplified * the scroll duration has been set to 0 because in case of a delay the scroll target element might not be available any more if validation results lead to (automatical) route changes
shauke
force-pushed
the
bugfix/auto-scroll
branch
from
ec3c574
to
b8babcf
Compare
shauke
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
When validation messages appear in the PWA during checkout, the page scrolls down, causing the focus to shift away from the message. This disrupts user experience as the message is no longer in view.
Issue Number: Closes #
What Is the New Behavior?
The scroll behavior of the basket validation results component has been simplified. The scroll duration has been set to 0 because in case of a delay the scroll target element might not be available any more if validation results lead to (automatical) route changes.
Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information
AB#95248
AB#93133