Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add posibility to deploy nginx with selected features #386

Merged
merged 1 commit into from Sep 28, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Sep 25, 2020

PR Type

[x] Documentation changes
[x] Application / infrastructure changes

What Is the Current Behavior?

Nginx container ist always deployed with enabled cache, which is not suitable for edit environments, where changes of ICM related data should be visible immediately in SSR responses.

What Is the New Behavior?

Features can be switched off via environment variables.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi added documentation Improvements or additions to documentation enhancement Enhancement to an existing feature labels Sep 25, 2020
@dhhyi dhhyi added this to the 0.24 milestone Sep 25, 2020
@dhhyi dhhyi self-assigned this Sep 25, 2020
@dhhyi dhhyi added this to In progress in Current via automation Sep 25, 2020
@dhhyi dhhyi marked this pull request as ready for review September 25, 2020 17:49
shauke
shauke previously approved these changes Sep 27, 2020
Copy link
Member

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can be merged with a little documentation improvement. ;)

nginx/README.md Outdated Show resolved Hide resolved
Current automation moved this from In progress to Reviewer approved Sep 27, 2020
@dhhyi dhhyi changed the title feat: deploy nginx with certain features disabled feat: add posibility to deploy nginx with selected features Sep 27, 2020
Current automation moved this from Reviewer approved to Review in progress Sep 27, 2020
@dhhyi dhhyi requested a review from shauke September 27, 2020 12:56
Current automation moved this from Review in progress to Reviewer approved Sep 27, 2020
@dhhyi dhhyi merged commit 1f0c4a4 into develop Sep 28, 2020
Current automation moved this from Reviewer approved to Done Sep 28, 2020
@dhhyi dhhyi deleted the feature/disable-nginx-cache branch September 28, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Enhancement to an existing feature
Projects
Current
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants