Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: product selector memoization #528

Merged
merged 28 commits into from
Feb 23, 2021

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Feb 3, 2021

PR Type

[x] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

products selectors use lodash memoize.

What Is the New Behavior?

  • proper usage of memoized selectors for products selectors
  • prevent merge operations in products reducer by splitting up state and save additionally retrieved data in separate places
  • migrated almost all product related components to use product context

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi self-assigned this Feb 3, 2021
@dhhyi dhhyi added the refactoring Refactoring of current code label Feb 3, 2021
@dhhyi dhhyi added this to In progress in Current via automation Feb 3, 2021
@dhhyi dhhyi added this to In progress in Technical Debt via automation Feb 3, 2021
@dhhyi dhhyi force-pushed the refactor/product-selector-memoization branch 10 times, most recently from 376663e to be437c6 Compare February 10, 2021 13:28
@dhhyi dhhyi force-pushed the refactor/product-selector-memoization branch 14 times, most recently from 6c68294 to 2b27cb8 Compare February 16, 2021 09:15
@dhhyi dhhyi requested a review from MaxKless February 16, 2021 11:25
@dhhyi dhhyi force-pushed the refactor/product-selector-memoization branch from e2f1574 to 51ba25c Compare February 22, 2021 23:11
MaxKless
MaxKless previously approved these changes Feb 23, 2021
Current automation moved this from In progress to Review in progress Feb 23, 2021
@dhhyi
Copy link
Collaborator Author

dhhyi commented Feb 23, 2021

Thanks for the review @MaxKless.
Waiting for merge of #496 😃

@dhhyi dhhyi merged commit ac0b35a into develop Feb 23, 2021
Technical Debt automation moved this from In progress to Done Feb 23, 2021
Current automation moved this from Review in progress to Done Feb 23, 2021
@dhhyi dhhyi deleted the refactor/product-selector-memoization branch February 23, 2021 16:07
@suschneider suschneider moved this from Done to Public Review in Current Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of current code
Projects
Current
  
Public Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants